Hi Sascha, On Wednesday 19 June 2013 07:30:54 Sascha Hauer wrote: > On Wed, Jun 19, 2013 at 02:39:48AM +0200, Laurent Pinchart wrote: > > On Monday 10 June 2013 15:56:01 Laurent Pinchart wrote: > > > Hi Sascha, > > > > > > I'm sorry for the late reply. > > > > > > Great patch set, thank you. It's very helpful. > > > > Should I got ahead and apply the patch with the proposed modifications > > below ? > > That'd be nice. I'm a bit out of the loop at the moment and don't have > a setup handy to test the changes.
Pushed, thank you. > > > No need to cast to a char * here, end is already a char *. > > > > > > What would you think about adding > > > > > > + /* endp can be NULL. To avoid spreading NULL checks across the > > > + * function, set endp to &end in that case. > > > + */ > > > + if (endp == NULL) > > > + endp = &end; > > > > > > at the beginning of the function and removing the endp NULL checks that > > > are > > > spread across the code below ? > > Good idea. Your other suggestions also look good. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
