Restarting stream fails quite often. Small delay is between urb killing
and stream stop command - likely to give harware some time to process
killed urbs.

Signed-off-by: Antti Palosaari <cr...@iki.fi>
---
 drivers/staging/media/msi3101/sdr-msi3101.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/media/msi3101/sdr-msi3101.c 
b/drivers/staging/media/msi3101/sdr-msi3101.c
index c73f1d9..2180bf8 100644
--- a/drivers/staging/media/msi3101/sdr-msi3101.c
+++ b/drivers/staging/media/msi3101/sdr-msi3101.c
@@ -959,7 +959,7 @@ static int msi3101_ctrl_msg(struct msi3101_state *s, u8 
cmd, u32 data)
        msi3101_dbg_usb_control_msg(s->udev,
                        request, requesttype, value, index, NULL, 0);
 
-       ret = usb_control_msg(s->udev, usb_rcvctrlpipe(s->udev, 0),
+       ret = usb_control_msg(s->udev, usb_sndctrlpipe(s->udev, 0),
                        request, requesttype, value, index, NULL, 0, 2000);
 
        if (ret)
@@ -1300,12 +1300,15 @@ static int msi3101_stop_streaming(struct vb2_queue *vq)
        if (mutex_lock_interruptible(&s->v4l2_lock))
                return -ERESTARTSYS;
 
-       msi3101_ctrl_msg(s, CMD_STOP_STREAMING, 0);
-
        if (s->udev)
                msi3101_isoc_cleanup(s);
 
        msi3101_cleanup_queued_bufs(s);
+
+       /* according to tests, at least 700us delay is required  */
+       msleep(20);
+       msi3101_ctrl_msg(s, CMD_STOP_STREAMING, 0);
+
        mutex_unlock(&s->v4l2_lock);
 
        return 0;
-- 
1.7.11.7

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to