On 08/26/14 10:25, Mark Brown wrote:
> From: Mark Brown <broo...@linaro.org>
>
> Currently arm64 does not support PCI but it does support v4l2. Since the
> PCI skeleton driver is built unconditionally as a module with no dependency
> on PCI this causes build failures for arm64 allmodconfig. Fix this by
> defining a symbol VIDEO_PCI_SKELETON for the skeleton and conditionalising
> the build on that.
>
> Signed-off-by: Mark Brown <broo...@linaro.org>
> ---
>
> The patch adding the Makefile was added to the Documentation tree,
> either it should be reverted or something like this added on top.
>
> Documentation/video4linux/Makefile | 2 +-
> drivers/media/v4l2-core/Kconfig | 7 +++++++
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/video4linux/Makefile
> b/Documentation/video4linux/Makefile
> index d58101e788fc..65a351d75c95 100644
> --- a/Documentation/video4linux/Makefile
> +++ b/Documentation/video4linux/Makefile
> @@ -1 +1 @@
> -obj-m := v4l2-pci-skeleton.o
> +obj-$(CONFIG_VIDEO_PCI_SKELETON) := v4l2-pci-skeleton.o
> diff --git a/drivers/media/v4l2-core/Kconfig b/drivers/media/v4l2-core/Kconfig
> index 9ca0f8d59a14..2b368f711c9e 100644
> --- a/drivers/media/v4l2-core/Kconfig
> +++ b/drivers/media/v4l2-core/Kconfig
> @@ -25,6 +25,13 @@ config VIDEO_FIXED_MINOR_RANGES
>
> When in doubt, say N.
>
> +config VIDEO_PCI_SKELETON
> + tristate "Skeleton PCI V4L2 driver"
> + depends on PCI && COMPILE_TEST
&& ?? No, don't require COMPILE_TEST.
However, PCI || COMPILE_TEST would allow it to build on arm64
if COMPILE_TEST is enabled, guaranteeing build errors.
Is that what should happen? I suppose so...
> + ---help---
> + Enable build of the skeleton PCI driver, used as a reference
> + when developign new drivers.
> +
> # Used by drivers that need tuner.ko
> config VIDEO_TUNER
> tristate
>
--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
