On Wed, 08 Oct 2014 15:22:43 +0200
Jacek Anaszewski <j.anaszew...@samsung.com> wrote:
> Hi Hans,
>
> On 10/08/2014 02:42 PM, Hans de Goede wrote:
> > Hi,
> >
> > On 10/08/2014 10:46 AM, Jacek Anaszewski wrote:
> >> The plugin provides support for the media device on Exynos4 SoC.
> >> Added is also a media device configuration file parser.
> >> The media configuration file is used for conveying information
> >> about media device links that need to be established as well
> >> as V4L2 user control ioctls redirection to a particular
> >> sub-device.
> >>
> >> The plugin performs single plane <-> multi plane API conversion,
> >> video pipeline linking and takes care of automatic data format
> >> negotiation for the whole pipeline, after intercepting
> >> VIDIOC_S_FMT or VIDIOC_TRY_FMT ioctls.
> >>
> >> Signed-off-by: Jacek Anaszewski <j.anaszew...@samsung.com>
> >> Acked-by: Kyungmin Park <kyungmin.p...@samsung.com>
> >> Cc: Mauro Carvalho Chehab <mche...@osg.samsung.com>
> >> Cc: Hans Verkuil <hans.verk...@cisco.com>
> >> ---
> >> configure.ac | 1 +
> >> lib/Makefile.am | 5 +-
> >> lib/libv4l-exynos4-camera/Makefile.am | 7 +
> >> .../libv4l-devconfig-parser.h | 145 ++
> >> lib/libv4l-exynos4-camera/libv4l-exynos4-camera.c | 2486
> >> ++++++++++++++++++++
> >> 5 files changed, 2642 insertions(+), 2 deletions(-)
> >> create mode 100644 lib/libv4l-exynos4-camera/Makefile.am
> >> create mode 100644 lib/libv4l-exynos4-camera/libv4l-devconfig-parser.h
> >> create mode 100644 lib/libv4l-exynos4-camera/libv4l-exynos4-camera.c
> >
> > Ugh, that is a big plugin. Can you please split out the parser stuff
> > into a separate file ?
>
> Yes, I tried to split it, but spent so much time fighting with
> autotools, that I decided to submit it in this form and ask
> more experienced v4l-utils build system maintainers for the advice.
> I mentioned this in the cover letter.
>
What autotools issue in particular?
The following change followed by "automake && ./configure" should be
enough to add a new file libv4l-devconfig-parser.c:
diff --git a/lib/libv4l-exynos4-camera/Makefile.am
b/lib/libv4l-exynos4-camera/Makefile.am
index 3552ec8..14d461a 100644
--- a/lib/libv4l-exynos4-camera/Makefile.am
+++ b/lib/libv4l-exynos4-camera/Makefile.am
@@ -2,6 +2,6 @@ if WITH_V4L_PLUGINS
libv4l2plugin_LTLIBRARIES = libv4l-exynos4-camera.la
endif
-libv4l_exynos4_camera_la_SOURCES = libv4l-exynos4-camera.c
+libv4l_exynos4_camera_la_SOURCES = libv4l-exynos4-camera.c
libv4l-devconfig-parser.c
libv4l_exynos4_camera_la_CPPFLAGS = -fvisibility=hidden -std=gnu99
libv4l_exynos4_camera_la_LDFLAGS = -avoid-version -module -shared
-export-dynamic -lpthread
If you wanted to completely reset the build environment you could
even use "git clean", FWIW I have this "git distclean" alias in
~/.gitconfig:
[alias]
distclean = clean -f -d -X
You'll need to rerun "autoreconf -i" after such a cleanup.
Ciao,
Antonio
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
