Em Tue, 27 Oct 2015 01:01:35 +0200
Sakari Ailus <sakari.ai...@iki.fi> escreveu:
> It will be needed in struct media_pipeline shortly.
>
> Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com>
Reviewed-by: Mauro Carvalho Chehab <mche...@osg.samsung.com>
(but see below)
> ---
> include/media/media-entity.h | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/include/media/media-entity.h b/include/media/media-entity.h
> index fc54192..dde9a5f 100644
> --- a/include/media/media-entity.h
> +++ b/include/media/media-entity.h
> @@ -87,6 +87,16 @@ struct media_entity_enum {
> int idx_max;
> };
>
> +struct media_entity_graph {
Not a problem on this patch itself, but since you're touching this
struct, it would be nice to take the opportunity and document it ;)
Regards,
Mauro
> + struct {
> + struct media_entity *entity;
> + struct list_head *link;
> + } stack[MEDIA_ENTITY_ENUM_MAX_DEPTH];
> +
> + DECLARE_BITMAP(entities, MEDIA_ENTITY_ENUM_MAX_ID);
> + int top;
> +};
> +
> struct media_pipeline {
> };
>
> @@ -429,16 +439,6 @@ static inline bool media_entity_enum_intersects(struct
> media_entity_enum *e,
> return bitmap_intersects(e->e, f->e, min(e->idx_max, f->idx_max));
> }
>
> -struct media_entity_graph {
> - struct {
> - struct media_entity *entity;
> - struct list_head *link;
> - } stack[MEDIA_ENTITY_ENUM_MAX_DEPTH];
> -
> - DECLARE_BITMAP(entities, MEDIA_ENTITY_ENUM_MAX_ID);
> - int top;
> -};
> -
> #define gobj_to_entity(gobj) \
> container_of(gobj, struct media_entity, graph_obj)
>
--
Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
