Hi Helen, On Tue, Mar 29, 2016 at 08:49:47PM -0300, Helen Mae Koike Fornazier wrote: > According to the V4L2 API, the VIDIOC_STREAMON ioctl should return EPIPE > if there is a format mismatch in the pipeline configuration. > > As the .vidioc_streamon in the v4l2_ioctl_ops usually forwards the error > caused by the v4l2_subdev_link_validate_default (if it is in use), it > should return -EPIPE when it detect the mismatch. > > When an entity is connected to a non enabled link, > media_entity_pipeline_start should return -ENOLINK, as the link does not > exist. > > Signed-off-by: Helen Mae Koike Fornazier <[email protected]>
Acked-by: Sakari Ailus <[email protected]> While at it, could you change the documentation of VIDIOC_STREAMON as well? It documents EPIPE but no ENOLINK. I think it could be e.g. "The driver implements Media controller interface and the pipeline link configuration is invalid." -- Kind regards, Sakari Ailus e-mail: [email protected] XMPP: [email protected] -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
