> @@ -1190,6 +1207,20 @@ out_unlock:
> return ret;
> }
>
> +static int adv7180_of_parse(struct adv7180_state *state)
Since there is nothing of specific in here anymore the name should be
changed, or maybe just inline the code directly in probe.
> +{
> + struct i2c_client *client = state->client;
> +
> + state->pwdn_gpio = devm_gpiod_get_optional(&client->dev, "pwdn",
I'd use "powerdown", vowels don't cost extra ;):
> + GPIOD_OUT_HIGH);
> + if (IS_ERR(state->pwdn_gpio)) {
> + v4l_err(client, "request for power pin failed\n");
Include the error number in the message.
> + return PTR_ERR(state->pwdn_gpio);
> + }
> +
> + return 0;
> +}
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
