devm_pinctrl_get() can fail so we should check for that.

Fixes: 0a6824bc10de ('[media] v4l2: blackfin: select proper pinctrl state in 
ppi_set_params if CONFIG_PINCTRL is enabled')
Signed-off-by: Dan Carpenter <[email protected]>

diff --git a/drivers/media/platform/blackfin/ppi.c 
b/drivers/media/platform/blackfin/ppi.c
index cff63e5..b8f3d9f 100644
--- a/drivers/media/platform/blackfin/ppi.c
+++ b/drivers/media/platform/blackfin/ppi.c
@@ -214,6 +214,8 @@ static int ppi_set_params(struct ppi_if *ppi, struct 
ppi_params *params)
        if (params->dlen > 24 || params->dlen <= 0)
                return -EINVAL;
        pctrl = devm_pinctrl_get(ppi->dev);
+       if (IS_ERR(pctrl))
+               return PTR_ERR(pctrl);
        pstate = pinctrl_lookup_state(pctrl,
                                      pin_state[(params->dlen + 7) / 8 - 1]);
        if (pinctrl_select_state(pctrl, pstate))
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to