On 13/03/15 18:14, Alex Dowad wrote:
> The 'arg' argument to copy_thread() is only ever used when forking a new
> kernel thread. Hence, rename it to 'kthread_arg' for clarity (and consistency
> with do_fork() and other arch-specific implementations of copy_thread()).
>
> Signed-off-by: Alex Dowad <alexinbeij...@gmail.com>
> ---
> arch/metag/kernel/process.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/arch/metag/kernel/process.c b/arch/metag/kernel/process.c
> index 483dff9..dcb4609 100644
> --- a/arch/metag/kernel/process.c
> +++ b/arch/metag/kernel/process.c
> @@ -174,8 +174,11 @@ void show_regs(struct pt_regs *regs)
> show_trace(NULL, (unsigned long *)regs->ctx.AX[0].U0, regs);
> }
>
> +/*
> + * Copy architecture-specific thread state
> + */
> int copy_thread(unsigned long clone_flags, unsigned long usp,
> - unsigned long arg, struct task_struct *tsk)
> + unsigned long kthread_arg, struct task_struct *tsk)
> {
> struct pt_regs *childregs = task_pt_regs(tsk);
> void *kernel_context = ((void *) childregs +
> @@ -204,10 +207,11 @@ int copy_thread(unsigned long clone_flags, unsigned
> long usp,
> childregs->ctx.AX[0].U0 = (unsigned long) kernel_context;
> /* Set D1Ar1=arg and D1RtP=usp (fn) */Please update this comment too (ctx.DX[3].U1 stores the D1Ar1 register). Other than that: Acked-by: James Hogan <james.ho...@imgtec.com> I'll assume you plan to get all these patches merged together rather than via individual arch trees unless you say otherwise. Cheers James > childregs->ctx.DX[4].U1 = usp; > - childregs->ctx.DX[3].U1 = arg; > + childregs->ctx.DX[3].U1 = kthread_arg; > tsk->thread.int_depth = 2; > return 0; > } > + > /* > * Get a pointer to where the new child's register block should have > * been pushed. >
signature.asc
Description: OpenPGP digital signature
