On 3/16/10 7:34 PM, Anton Vorontsov wrote: > Some hosts have an extended SDHCI iomem size, so the driver should > only print errors if the iomem size is less than 0x100.
With this change you allow a bigger resource than we really need. I think you should also change request_mem_region and ioremap to only request and map the actual needed size. (0x100) > > Signed-off-by: Anton Vorontsov <[email protected]> > --- > drivers/mmc/host/sdhci-pltfm.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c > index 217b911..b6ee0d7 100644 > --- a/drivers/mmc/host/sdhci-pltfm.c > +++ b/drivers/mmc/host/sdhci-pltfm.c > @@ -61,7 +61,7 @@ static int __devinit sdhci_pltfm_probe(struct > platform_device *pdev) > goto err; > } > > - if (resource_size(iomem) != 0x100) > + if (resource_size(iomem) < 0x100) > dev_err(&pdev->dev, "Invalid iomem size. You may " > "experience problems.\n"); > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
