On Mon, 2010-06-07 at 01:47 -0400, Chris Ball wrote:
> Hi Maxim,
>
> >> It looks like your editor is set to four-space instead of
> >> eight-space tab characters, else you wouldn't be using so
> >> many tabs here.
>
> > Nope, I think indention is right here.
> >
> > the break is inside 'if' condition.
>
> Please look again, I think you're mistaken. For example, why do you
> use seven tab characters for the "& SDHCI_CARD_PRESENT" after the if
> line? With eight-space tabs, it looks like this (converted to
> spaces):
>
> + if (sdhci_readl(host, SDHCI_PRESENT_STATE)
> + & SDHCI_CARD_PRESENT)
> {
Ah, this.
I just break the line to avoid hitting the 80 char limit...
You probably meant I need to write:
+ if (sdhci_readl(host, SDHCI_PRESENT_STATE)
+ & SDHCI_CARD_PRESENT) {
Nothing against it,
Best regards,
Maxim Levitsky
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
