On Wed, 16 Jun 2010 08:49:54 +0200 Marek Szyprowski <[email protected]> wrote:
> Signed-off-by: Marek Szyprowski <[email protected]> > Signed-off-by: Kyungmin Park <[email protected]> > --- > drivers/mmc/host/sdhci-s3c.c | 20 ++++++++++++++++++++ > 1 files changed, 20 insertions(+), 0 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c > index af21792..ad30f07 100644 > --- a/drivers/mmc/host/sdhci-s3c.c > +++ b/drivers/mmc/host/sdhci-s3c.c > @@ -365,6 +365,26 @@ static int __devinit sdhci_s3c_probe(struct > platform_device *pdev) > > static int __devexit sdhci_s3c_remove(struct platform_device *pdev) > { > + struct sdhci_host *host = platform_get_drvdata(pdev); > + struct sdhci_s3c *sc = sdhci_priv(host); > + int ptr; > + > + sdhci_remove_host(host, 1); > + > + for (ptr = 0; ptr < 3; ptr++) { > + clk_disable(sc->clk_bus[ptr]); > + clk_put(sc->clk_bus[ptr]); > + } > + clk_disable(sc->clk_io); > + clk_put(sc->clk_io); > + > + iounmap(host->ioaddr); > + release_resource(sc->ioarea); > + kfree(sc->ioarea); > + > + sdhci_free_host(host); > + platform_set_drvdata(pdev, NULL); > + > return 0; > } This looks like it fixes a pretty serious omission. What happens if the user rmmods this driver on a 2.6.34 kernel? Because I have a suspicion that this fix should be backported into 2.6.34.x? -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
