On Tue, 13 Jul 2010 11:32:33 +0900 Yusuke Goda <[email protected]> wrote:
> Hi Andrew > > Andrew Morton wrote: > > On Wed, 07 Jul 2010 11:01:20 +0900 > > Yusuke Goda <[email protected]> wrote: > > > >> Signed-off-by: Yusuke Goda <[email protected]> > >> --- > >> drivers/mmc/host/tmio_mmc.c | 2 +- > >> 1 files changed, 1 insertions(+), 1 deletions(-) > >> > >> diff --git a/drivers/mmc/host/tmio_mmc.c b/drivers/mmc/host/tmio_mmc.c > >> index ee7d0a5..cac1c97 100644 > >> --- a/drivers/mmc/host/tmio_mmc.c > >> +++ b/drivers/mmc/host/tmio_mmc.c > >> @@ -661,7 +661,7 @@ static int tmio_mmc_start_data(struct tmio_mmc_host > >> *host, > >> data->blksz, data->blocks); > >> > >> /* Hardware cannot perform 1 and 2 byte requests in 4 bit mode */ > >> - if (data->blksz < 4 && host->mmc->ios.bus_width == MMC_BUS_WIDTH_4) { > >> + if (data->blksz < 2 && host->mmc->ios.bus_width == MMC_BUS_WIDTH_4) { > >> pr_err("%s: %d byte block unsupported in 4 bit mode\n", > >> mmc_hostname(host->mmc), data->blksz); > >> return -EINVAL; > > > > Again, please provide a suitable description for this change. > I think the data size is not limited by MMC_BUS_WIDTH_x. > I confirmed that data transmission of 2Byte was performed without a problem. This patch hasn't been picked up. I'm assuming that's because Andrew is still unhappy with the changelog. Andrew, how about something like, "When running in 4-bit bus width mode, it is entirely possible to transfer data in block sizes of 2 bytes and larger. Relax the conditional check to allow 2-byte data block transfers which were previously disallowed." Yusuke, have I interpreted your changelog correctly? Also note that your patch should remove the comment above the conditional that says, "Hardware cannot perform 1 and 2 byte requests in 4 bit mode". -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
