On Wed, 1 Sep 2010, Bing Zhao wrote:
> Quoted Michal Miroslaw's comment:
>
> Simplified SDIO spec v.2.00 (section 6.14 - Bus State Diagram)
> suggests, that initialization commands (CMD5, CMD3) are not accepted
> in CMD state. As the card stays in that state on powered suspend (no
> resetting CMD52 nor power cycle is issued) then reinitialization
> should be entirely skipped on resume unless the power was lost between
> suspend and resume (or card was temporarily removed from the slot).
>
> Signed-off-by: Bing Zhao <[email protected]>
Comments below.
> + /*
> + * Simplified SDIO spec v2.00 (section 6.14 - Bus State Diagram)
> + * suggests that initialization should be skipped on powered resume.
> + */
> + if (!(host->pm_flags & MMC_PM_KEEP_POWER)) {
> + err = mmc_sdio_init_card(host, host->ocr, host->card,
> + host->pm_flags & MMC_PM_KEEP_POWER);
> + }
Please look at the if() condition, and at the last argument to
mmc_sdio_init_card(), then ponder.
I think the proper fix goes _inside_ mmc_sdio_init_card() as there are
certainly still validation checks which are appropriate to perform.
Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
