On 10/14/10 02:04, Michał Mirosław wrote: > On Wed, Oct 13, 2010 at 06:15:19PM -0700, Randy Dunlap wrote: >> Fix kconfig dependency warning to satisfy dependencies: >> >> warning: (MMC_CB710 && MMC && PCI) selects CB710_CORE which has unmet direct >> dependencies (MISC_DEVICES && PCI) >> >> Signed-off-by: Randy Dunlap <[email protected]> >> Cc: <[email protected]> >> --- >> drivers/mmc/host/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> --- linux-next-20101013.orig/drivers/mmc/host/Kconfig >> +++ linux-next-20101013/drivers/mmc/host/Kconfig >> @@ -394,7 +394,7 @@ config MMC_TMIO >> >> config MMC_CB710 >> tristate "ENE CB710 MMC/SD Interface support" >> - depends on PCI >> + depends on PCI && MISC_DEVICES >> select CB710_CORE >> help >> This option enables support for MMC/SD part of ENE CB710/720 Flash > > Is this really necessary? MISC_DEVICES is only a submenu enabler, not > a real dependency. > > Maybe just select MISC_DEVICES instead? User/developer should not have > to know that for this specific MMC controller he has to first enable some > other device burried somewhere in the config tree.
Yes, I'll resubmit using "select". (like I did with another mmc + memstick patch) thanks, -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
