Hi, On Tue, Oct 19, 2010 at 09:47:24PM +0200, Wolfram Sang wrote: > On Tue, Oct 19, 2010 at 11:27:22AM -0700, Philip Rakity wrote: > > Our controller has private registers that are useful to see on error. > > define a new host->ops to allow these registers to be printed > > > > Signed-off-by: Philip Rakity <[email protected]> > > I wonder if we really need such a thing in the mainline kernel? It is probably > used for debugging the driver?
There's another question: why merge a patch that adds a hook that isn't used by anything currently in the kernel? Should we wait until this is accompanied by a print_private_info() implementation in a mainline driver, rather than adding it proactively? Thanks, -- Chris Ball <[email protected]> <http://printf.net/> One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
