Hi Linus, Trying out CLKGATE=y on my x86 laptop with sdhci-pci:
<boot, slots are empty> [ 10.080469] Registered led device: mmc0:: [ 10.080595] mmc0: SDHCI controller on PCI [0000:0d:00.0] using DMA [ 10.107996] mmc0: frequency set to 0 in disable function, this means the clock is already disabled. [ 10.122164] Registered led device: mmc1:: [ 10.122237] mmc1: SDHCI controller on PCI [0000:17:00.0] using DMA [ 10.136067] mmc0: frequency set to 0 in disable function, this means the clock is already disabled. [ 10.164089] mmc0: frequency set to 0 in disable function, this means the clock is already disabled. [ 10.192076] mmc0: frequency set to 0 in disable function, this means the clock is already disabled. [ 10.291095] mmc1: frequency set to 0 in disable function, this means the clock is already disabled. [ 10.319029] mmc1: frequency set to 0 in disable function, this means the clock is already disabled. <insert a card, mount> [ 1569.970580] mmc0: new SDHC card at address d555 [ 1744.842376] mmcblk0: mmc0:d555 SD04G 3.79 GiB [ 1744.845224] mmcblk0: p1 [ 1745.312968] EXT4-fs (mmcblk0p1): mounted filesystem without journal. <umount, remove card> [ 1795.000070] mmc0: card d555 removed [ 1795.029868] mmc0: frequency set to 0 in disable function, this means the clock is already disabled. [ 1795.037021] mmc0: frequency set to 0 in disable function, this means the clock is already disabled. [ 1795.037043] mmc0: frequency set to 0 in disable function, this means the clock is already disabled. [ 1795.037065] mmc0: frequency set to 0 in disable function, this means the clock is already disabled. [ 1795.037086] mmc0: frequency set to 0 in disable function, this means the clock is already disabled. [ 1795.058904] mmc0: frequency set to 0 in disable function, this means the clock is already disabled. [ 1795.086940] mmc0: frequency set to 0 in disable function, this means the clock is already disabled. [ 1795.093011] mmc0: frequency set to 0 in disable function, this means the clock is already disabled. [ 1795.093048] mmc0: frequency set to 0 in disable function, this means the clock is already disabled. [ 1795.093084] mmc0: frequency set to 0 in disable function, this means the clock is already disabled. [ 1795.093115] mmc0: frequency set to 0 in disable function, this means the clock is already disabled. [ 1795.116854] mmc0: frequency set to 0 in disable function, this means the clock is already disabled. [ 1795.120881] mmc0: frequency set to 0 in disable function, this means the clock is already disabled. [ 1795.120938] mmc0: frequency set to 0 in disable function, this means the clock is already disabled. [ 1795.120972] mmc0: frequency set to 0 in disable function, this means the clock is already disabled. [ 1795.121001] mmc0: frequency set to 0 in disable function, this means the clock is already disabled. [ 1795.121030] mmc0: frequency set to 0 in disable function, this means the clock is already disabled. [ 1795.121058] mmc0: frequency set to 0 in disable function, this means the clock is already disabled. [ 1795.121083] mmc0: frequency set to 0 in disable function, this means the clock is already disabled. Questions: * Are we expecting mmc_host_clk_gate_delayed() to be called so often with host->ios.clock == 0? There's a full log with CONFIG_MMC_DEBUG=y at http://chris.printf.net/mmc-clkgate-debug in case it helps you see what's going on. * If you think the current behavior should stay, we would at least want to convert it to a dev_dbg so that it's only visible under MMC_DEBUG=y, right? Thanks! - Chris. -- Chris Ball <[email protected]> <http://printf.net/> One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
