On Fri, Feb 4, 2011 at 11:50 PM, Matt Fleming <[email protected]> wrote:
> On Fri, 4 Feb 2011 11:17:54 +0000
> Will Newton <[email protected]> wrote:
>
>> We need to run the card detect tasklet at the end of slot
>> initialisation as it is possible that a card has been inserted prior
>> to boot, so we miss the insertion interrupt and now the card is
>> sitting there inserted but with no power to it.
>
> So when powering up the board with a card already inserted, an interrupt
> isn't generated? If that's the case then we haven't "missed" an
> interrupt as one was never generated, right?

I believe it starts up with interrupts masked so we don't actually see
any interrupts until
we unmask - and it isn't clear from the documentation whether or not
an interrupt is generated.

> If the answer to the above questions is "yes", then you can add my
> Reviewed-by (though it might be worth changing the bit about missing
> an interrupt in the commit message). Otherwise, I would have expected
> the usual interrupt machinery to take care of detecting the inserted
> card?

Ok I'll update that, thanks for the review!
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to