>> + if (pm_runtime_suspended()) {
>> + host->waking_up = 1;
>> + /* Note that we disable temporarly the interrupt until we do
>> the
>> + * resume. If we don't then we'll get constantly interrupted
>> + * until we actually resume.
>> + *
>> + * as the irq is shared, this might not be very friendly to our
>> + * irq sharers but the pm_runtime workqueue should really be
>> + * called soon.
>
> Instead of disabling the IRQ, would it be possible to tell the device
> to stop generating an interrupt request?
Well, the device is power gated, so any access to it will cause a bus
timeout (depending of the platform)
>> + */
>> + disable_irq_nosync(irq);
>> + pm_runtime_get(host->mmc->parent);
>
> Does this pm_runtime_get() have a corresponding pm_runtime_put()? I
> didn't notice one anywhere.
oups, forgot to add the corresponding snippet in sdhci_runtime_resume:
if (host->waking_up) {
pm_runtime_put();
host->waking_up = 0;
}
>>
>
> Surely this doesn't belong in the patch.
yep sorry, I should stop doing git commit -a...
Pierre
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
