Hi Wolfram,

> -----Original Message-----
> From: Wolfram Sang [mailto:[email protected]]
> Sent: Friday, March 04, 2011 5:18 PM
> To: Nath, Arindam
> Cc: [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; Su, Henry; Lu,
> Aaron; [email protected]
> Subject: Re: [PATCH v2 02/12] mmc: sd: add support for signal voltage
> switch procedure
> 
> 
> > +   if (host->version >= SDHCI_SPEC_300)
> > +           caps[1] = sdhci_readl(host, SDHCI_CAPABILITIES_1);
> 
> Now caps[1] can be uninitialized (didn't the compiler warn about this?)

Surprisingly, there was no compiler warning on my setup. I will take care of it.

Thanks,
Arindam

> Maybe
> 
>       caps[1] = host->version... ? sdhci_readl() : 0
> 
> (or simply an else branch)?
> 
> Regards,
> 
>    Wolfram
> 
> --
> Pengutronix e.K.                           | Wolfram Sang
> |
> Industrial Linux Solutions                 | http://www.pengutronix.de/
> |

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to