On Mon, Apr 04, 2011 at 11:48:57AM +0900, Jaehoon Chung wrote:
> Sometimes we can't add the device,but we didn't check any error status.
> Need to check error status for mmc_add_host.

Thanks, this is correct, but...

> -     mmc_add_host(mmc);
> +     ret = mmc_add_host(mmc);
> +     if (unlikely(ret))
> +             goto err_free_mmc;

... you are leaking the irq and the lcd_classdev here.

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Attachment: signature.asc
Description: Digital signature

Reply via email to