Hi Tony, > Add a driver for Elan Digital System's VUB300 chip > which is a USB connected SDIO/SDmem/MMC host controller. > A VUB300 chip enables a USB 2.0 or USB 1.1 connected host > computer to use SDIO/SD/MMC cards without the need for > a directly connected, for example via PCI, SDIO host > controller. > > Signed-off-by: Anthony F Olech <[email protected]> > --- > This is the forth submission attempt.
Looks to me that the concerns have not been addressed since last submission.
I had a few a while ago, but Arnd added to it and summed it up nicely:
http://ns3.spinics.net/lists/linux-mmc/msg06693.html
> There are no errors reported by scripts/checkpatch.pl
Just to make sure: This only means that there are no obvious (= detectable by
a script) flaws. That makes it ready for submission, not necessarily for
inclusion. So, just resending will not be enough.
> This driver has been tested on
> a) 32bit x86
> b) 64bit x86
> c) dual processor
> d) PowerPC
The test coverage is great, yet the driver needs to comply to the kernel coding
rules. I'd suggest to look at Arnd's review and fix the issues.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
