On Tuesday 26 April 2011, Colin Cross wrote:
> On Tue, Apr 26, 2011 at 6:22 AM, Arnd Bergmann <[email protected]> wrote:
> > On Saturday 23 April 2011, John Stultz wrote:
> >> From: Colin Cross <[email protected]>
> >>
> >> Set the GENHD_FL_EXT_DEVT flag, which will allocate minor numbers
> >> in major 259 for partitions past disk->minors.
> >>
> >> Also remove the use of disk_devt to determine devidx from md->disk.
> >> md->disk->first_minor is always initialized from devidx and can
> >> always be used to recover it.
> >>
> >> CC: Chris Ball <[email protected]>
> >> CC: Arnd Bergmann <[email protected]>
> >> CC: Dima Zavin <[email protected]>
> >> Signed-off-by: Colin Cross <[email protected]>
> >> Signed-off-by: John Stultz <[email protected]>
> >
> > The new code looks reasonable, but wouldn't changing this be incompatible
> > with existing root file systems that contain static device nodes?
>
> I don't think so. Without this change, /dev/mmcblk0p1 will be (179,
> 1), /dev/mmcblk0p7 will be (179, 7), and /dev/mmcblk0p8 will be
> dropped. After this change, /dev/mmcblk0p1-7 will be the same, but
> /dev/mmcblk0p8 will be (259, <random number>). A root file system
> with static inodes will still have access to partitions 1-7, and will
> still not have access to dynamically-assigned partition 8.
Ah, I see.
The patch looks good to me then.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
