On Mon, May 23, 2011 at 11:01 AM, Arnd Bergmann <[email protected]> wrote: > On Monday 23 May 2011, Zhangfei Gao wrote: >> Delete sdhci-pxa.c and replace with sdhci-mmp2.c specificlly for mmp2 >> >> Signed-off-by: Zhangfei Gao <[email protected]> >> --- >> arch/arm/plat-pxa/include/plat/sdhci.h | 43 ++++- >> drivers/mmc/host/Kconfig | 9 +- >> drivers/mmc/host/Makefile | 2 +- >> drivers/mmc/host/sdhci-mmp2.c | 304 >> ++++++++++++++++++++++++++++++++ >> drivers/mmc/host/sdhci-pxa.c | 303 >> ------------------------------- >> 5 files changed, 349 insertions(+), 312 deletions(-) >> create mode 100644 drivers/mmc/host/sdhci-mmp2.c >> delete mode 100644 drivers/mmc/host/sdhci-pxa.c > > Hi Zhangfei, > > You should really try to improve your changelog texts. Instead of > the one-line summary that describes what you do 'Delete sdhci-pxa.c and > replace ...', please provide a paragraph explaining why you do it, > and what the bigger plan is here.
Thanks Arnd, will add more change log for explanation. > > Also, when renaming a file, please use 'git diff -M' or 'git format-patch -M' > to detect renames and generate a diff for the changes you did to the file. Double checked same patch coming using 'git format-patch -M' or 'git format-patch' , since the two files changes a lot. > > Arnd > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
