On Fri, Jul 15, 2011 at 02:51:34PM +0800, Nath, Arindam wrote: > Hi Philip, Zhangfei > > Do you have any comments on this patch? >
Hi all, This patch is sent for a while now and didn't seem to receive any notice yet...So, can you please take a look and give your comments? This is a bug fix for exsting code, if the re-tuning timer is deleted, the re-tuning will not happen again, that will cause problems for SDHC 3.0 hosts which utilize re-tuning mode 1. Thanks. > > > -----Original Message----- > > From: Aaron Lu [mailto:[email protected]] > > Sent: Monday, July 11, 2011 10:57 AM > > To: Chris Ball > > Cc: Nath, Arindam; [email protected]; Lu, Aaron > > Subject: [PATCH] mmc: sdhci: fix retuning timer wrongly deleted in > > sdhci_tasklet_finish > > > > Currently, the retuning timer for retuning mode 1 will be deleted in > > function sdhci_tasklet_finish after a mmc request done, which will > make > > retuning timing never trigger again. This patch fixed this problem. > > > > Signed-off-by: Aaron Lu <[email protected]> > > --- > > drivers/mmc/host/sdhci.c | 3 --- > > 1 files changed, 0 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c > > index 91d9892..6250bac 100644 > > --- a/drivers/mmc/host/sdhci.c > > +++ b/drivers/mmc/host/sdhci.c > > @@ -1863,9 +1863,6 @@ static void sdhci_tasklet_finish(unsigned long > > param) > > > > del_timer(&host->timer); > > > > - if (host->version >= SDHCI_SPEC_300) > > - del_timer(&host->tuning_timer); > > - > > mrq = host->mrq; > > > > /* > > -- > > 1.7.1 > > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
