Hi,

On Mon, Oct 17 2011, Adrian Hunter wrote:
>> Thanks -- any objection to using a bool type instead for allow_runtime_pm?
>
> None at all

Pushed to mmc-next for 3.2 with a conversion to bool, thanks:

diff --git a/drivers/mmc/host/sdhci-pci.c b/drivers/mmc/host/sdhci-pci.c
index c22d810..d833d9c 100644
--- a/drivers/mmc/host/sdhci-pci.c
+++ b/drivers/mmc/host/sdhci-pci.c
@@ -47,7 +47,7 @@ struct sdhci_pci_slot;
 
 struct sdhci_pci_fixes {
        unsigned int            quirks;
-       unsigned int            allow_runtime_pm:1;
+       bool                    allow_runtime_pm;
 
        int                     (*probe) (struct sdhci_pci_chip *);
 
@@ -73,7 +73,7 @@ struct sdhci_pci_chip {
        struct pci_dev          *pdev;
 
        unsigned int            quirks;
-       unsigned int            allow_runtime_pm:1;
+       bool                    allow_runtime_pm;
        const struct sdhci_pci_fixes *fixes;
 
        int                     num_slots;      /* Slots on controller */
@@ -307,19 +307,19 @@ static const struct sdhci_pci_fixes 
sdhci_intel_mrst_hc1_hc2 = {
 
 static const struct sdhci_pci_fixes sdhci_intel_mfd_sd = {
        .quirks         = SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC,
-       .allow_runtime_pm = 1,
+       .allow_runtime_pm = true,
        .probe_slot     = mfd_sd_probe_slot,
        .remove_slot    = mfd_sd_remove_slot,
 };
 
 static const struct sdhci_pci_fixes sdhci_intel_mfd_sdio = {
        .quirks         = SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC,
-       .allow_runtime_pm = 1,
+       .allow_runtime_pm = true,
 };
 
 static const struct sdhci_pci_fixes sdhci_intel_mfd_emmc = {
        .quirks         = SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC,
-       .allow_runtime_pm = 1,
+       .allow_runtime_pm = true,
        .probe_slot     = mfd_emmc_probe_slot,
        .remove_slot    = mfd_emmc_remove_slot,
 };

-- 
Chris Ball   <[email protected]>   <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to