Hi Tanmay and Philip, On Tue, Oct 25 2011, Tanmay Upadhyay wrote: > Signed-off-by: Philip Rakity <[email protected]> > Signed-off-by: Tanmay Upadhyay <[email protected]> > --- > drivers/mmc/host/Kconfig | 13 ++ > drivers/mmc/host/Makefile | 1 + > drivers/mmc/host/sdhci-pxav1.c | 256 > +++++++++++++++++++++++++++++++
By my script's count, 215 of the 256 lines in this file (84%) are simply duplicated from sdhci-pxav2.c, which makes me think we've failed at abstraction here. Can you have a think about how to do better, please? My intuition is that since there are only 41 lines of difference (actually, less, since the only difference on many of these is s/pxav2/pxav1/g), I'd rather see this become special-cases in the sdhci-pxav2.c code. Thanks, - Chris. -- Chris Ball <[email protected]> <http://printf.net/> One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
