Hi, On Tue, Sep 04 2012, Tomasz Figa wrote: > Some boards use fixed voltage regulator for vmmc supply (e.g. for eMMC > memories). MMC_CAP2_BROKEN_VOLTAGE must be enabled for them to operate > correctly. > > Cc: Ben Dooks <[email protected]> > Cc: Chris Ball <[email protected]> > CC: [email protected] > Signed-off-by: Tomasz Figa <[email protected]> > Signed-off-by: Kyungmin Park <[email protected]> > --- > Documentation/devicetree/bindings/mmc/mmc.txt | 1 + > drivers/mmc/host/sdhci-s3c.c | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt > b/Documentation/devicetree/bindings/mmc/mmc.txt > index 8a6811f..ecbde68 100644 > --- a/Documentation/devicetree/bindings/mmc/mmc.txt > +++ b/Documentation/devicetree/bindings/mmc/mmc.txt > @@ -16,6 +16,7 @@ Optional properties: > - wp-inverted: when present, polarity on the wp gpio line is inverted > - non-removable: non-removable slot (like eMMC) > - max-frequency: maximum operating clock frequency > +- broken-voltage: vmmc regulator does not allow voltage control > > Example: > > diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c > index 445910e..39715b8 100644 > --- a/drivers/mmc/host/sdhci-s3c.c > +++ b/drivers/mmc/host/sdhci-s3c.c > @@ -443,6 +443,9 @@ static int __devinit sdhci_s3c_parse_dt(struct device > *dev, > if (!ourhost->gpios) > return -ENOMEM; > > + if (of_get_property(node, "broken-voltage", 0)) > + pdata->host_caps2 |= MMC_CAP2_BROKEN_VOLTAGE; > + > /* get the card detection method */ > if (of_get_property(node, "broken-cd", 0)) { > pdata->cd_type = S3C_SDHCI_CD_NONE;
Is there a reason we can't make this a property on the regulator instead? Thanks, - Chris. -- Chris Ball <[email protected]> <http://printf.net/> One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
