On Tue, Sep 25, 2012 at 02:34:07PM +0800, yongd wrote: > From: yongd <[email protected]> [...] > And the better one to decide whether we use polling or not should be > the host driver itself. Actually, some host driver has already been > like this. Eg, in drivers/mmc/host/Au1xmmc.c, polling will be enabled > only after the board-specific card detection can't be set up successfully.
I guess it's not that simple. If you remove this, you have to add appropriate CAP_NEEDS_POLL for these drivers: linux/drivers/mmc/host$ git grep -l SDHCI_QUIRK_BROKEN_CARD_DETECTION | xargs grep -L NEEDS_POLL sdhci-esdhc-imx.c sdhci-of-esdhc.c sdhci-pci.c sdhci-pxav2.c sdhci-pxav3.c sdhci-s3c.c > Change-Id: I27774488a7b9191d7bc39699fd7d62ee21bbf157 > Signed-off-by: yongd <[email protected]> > --- > drivers/mmc/host/sdhci.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c > index 0e15c79..900d5f4 100644 > --- a/drivers/mmc/host/sdhci.c > +++ b/drivers/mmc/host/sdhci.c > @@ -2840,10 +2840,6 @@ int sdhci_add_host(struct sdhci_host *host) > if (caps[0] & SDHCI_CAN_DO_HISPD) > mmc->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED; > > - if ((host->quirks & SDHCI_QUIRK_BROKEN_CARD_DETECTION) && > - !(host->mmc->caps & MMC_CAP_NONREMOVABLE)) > - mmc->caps |= MMC_CAP_NEEDS_POLL; > - > /* If vqmmc regulator and no 1.8V signalling, then there's no UHS */ > host->vqmmc = regulator_get(mmc_dev(mmc), "vqmmc"); > if (IS_ERR(host->vqmmc)) { > -- > 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
