On Thursday, November 08, 2012, Jaehoon Chung <[email protected]> wrote:
> To ensure the stable clock need to enable before set the 
> DW_MMC_CARD_NEED_INIT flag.
> If set DW_MMC_CARD_NEED_INIT flag, wait for 80-clock before first command 
> after power-up.
As we have discussed, the location of 'dw_mci_setup_bus' seems proper in 
'dw_mci_set_ios'.
But commit message doesn't really hit me. Origin code can also ensure the same.
Mr. Newton, do you have any opinion?

Thanks,
Seungwon Jeon
> 
> Signed-off-by: Jaehoon Chung <[email protected]>
> Signed-off-by: Kyungmin Park <[email protected]>
> Acked-by: Seungwon Jeon <[email protected]>
> ---
> Changelog v2-v3:
>       - Modified the commit-message

>  drivers/mmc/host/dw_mmc.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> ---
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index c0667c8..a1369aa 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -683,9 +683,6 @@ static void __dw_mci_start_request(struct dw_mci *host,
>       if (host->pdata->select_slot)
>               host->pdata->select_slot(slot->id);
> 
> -     /* Slot specific timing and width adjustment */
> -     dw_mci_setup_bus(slot);
> -
>       host->cur_slot = slot;
>       host->mrq = mrq;
> 
> @@ -812,6 +809,9 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct 
> mmc_ios *ios)
>       if (drv_data && drv_data->set_ios)
>               drv_data->set_ios(slot->host, ios);
> 
> +     /* Slot specific timing and width adjustment */
> +     dw_mci_setup_bus(slot);
> +
>       switch (ios->power_mode) {
>       case MMC_POWER_UP:
>               set_bit(DW_MMC_CARD_NEED_INIT, &slot->flags);
> --
> 1.7.4.1
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to [email protected]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to