Hi Kevin, 2012/12/18 Kevin Liu <[email protected]>: > 2012/12/18 Johan Rudholm <[email protected]>: <...> >> + host->ios.signal_voltage = signal_voltage; >> err = host->ops->start_signal_voltage_switch(host, >> &host->ios); >> - mmc_host_clk_release(host); >> + if (err) { >> + host->ios.clock = clock; >> + mmc_set_ios(host); > > Since will power cycle and init card again so no need to set clock here?
This is true! We don't need to re-set the clock here. >> + mmc_host_clk_release(host); > > mmc_host_clk_hold and mmc_host_clk_release seems not in pairs? Also true, thanks. >> + >> return err; >> } >> > > I still prefer to update host->ios.signal_voltage after voltage switch > succeed. > And current code use host->ios as parameter while only the voltage > value will be used in start_signal_voltage_switch. > how do you think? I believe Ulf had some arguments against this, I don't remember exactly what they were. Maybe Ulf can elaborate a bit? Kind regards, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
