Hi, > -----Original Message----- > From: [email protected] > [mailto:[email protected]] On Behalf Of Chunhe Lan > Sent: Friday, March 08, 2013 4:14 PM > To: [email protected] > Cc: [email protected]; Chunhe Lan > Subject: [PATCH] mmc: sdhci-pltfm: Fix timeout on t4240's sdhci controller > > This patch fixes timeout problems on t4240's sdhci controller: > > mmc0: Too large timeout requested for CMD25! > mmc0: Too large timeout requested for CMD25! > mmc0: Too large timeout requested for CMD25! > > Signed-off-by: Chunhe Lan <[email protected]> > Cc: Chris Ball <[email protected]> > --- > drivers/mmc/host/sdhci-pltfm.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c > index 3145a78..9db7b12 100644 > --- a/drivers/mmc/host/sdhci-pltfm.c > +++ b/drivers/mmc/host/sdhci-pltfm.c > @@ -94,6 +94,7 @@ void sdhci_get_of_property(struct platform_device *pdev) > > if (of_device_is_compatible(np, "fsl,p2020-esdhc") || > of_device_is_compatible(np, "fsl,p1010-esdhc") || > + of_device_is_compatible(np, "fsl,t4240-esdhc") || > of_device_is_compatible(np, "fsl,mpc8536-esdhc")) > host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL; >
I think it's better to parse host specific property in host's driver rather than the shared sdhci-pltfm.c. Otherwise, sdhci_get_of_property will become bigger and bigger. How do you think? I have submitted below patch aim to do this: [PATCH 2/2] mmc: sdhci-pltfm: add function in sdhci_ops to parse dt property Thanks Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
