Hi Jeremie, I'm sorry for a very late review.

On Tue, Jul 09 2013, Jeremie Samuel wrote:
> @@ -118,7 +119,7 @@ struct sdhci_host {
>       enum led_brightness brightness;
>  #endif
>  
> -     spinlock_t lock;        /* Mutex */
> +     struct mutex lock;      /* Mutex */
>  
>       int flags;              /* Host attributes */
>  #define SDHCI_USE_SDMA               (1<<0)  /* Host is SDMA capable */

I think you need to modify many of the drivers/mmc/host/sdhci-*
drivers too -- for example:

sdhci-pxav3.c:

static int sdhci_pxav3_runtime_suspend(struct device *dev)
{
        struct sdhci_host *host = dev_get_drvdata(dev);
        struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
        unsigned long flags;

        if (pltfm_host->clk) {
                spin_lock_irqsave(&host->lock, flags);
[...]


sdhci-s3c.c:

static void sdhci_s3c_notify_change(struct platform_device *dev, int state)
{
        struct sdhci_host *host = platform_get_drvdata(dev);
#ifdef CONFIG_PM_RUNTIME
        struct sdhci_s3c *sc = sdhci_priv(host);
#endif
        unsigned long flags;

        if (host) {
                spin_lock_irqsave(&host->lock, flags);
[...]


Thanks,

- Chris.
-- 
Chris Ball   <[email protected]>   <http://printf.net/>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to