Hi Zhangfei, On 15 January 2014 14:11, zhangfei <[email protected]> wrote: > Hi, Sachin > > > > > On 01/15/2014 04:31 PM, Sachin Kamat wrote: >> >> mmc_gpio_get_cd returns a negative error value upon failure. >> However gpio_cd was initialised with the negated return value >> of the above function. This negation resulted in losing of the >> error value thereby triggering the code to take a wrong path as >> IS_ERR_VALUE(gpio_cd) now returned 0 even when mmc_gpio_get_cd >> returned an error value. This issue introduced by commit bf626e5550f2 >> ("mmc: dw_mmc: use slot-gpio to handle cd pin") caused card detection >> failure on Exynos5 boards which is now fixed by this patch. >> >> Signed-off-by: Sachin Kamat <[email protected]> >> Cc: Zhangfei Gao <[email protected]> >> Cc: Jaehoon Chung <[email protected]> >> Cc: Arnd Bergmann <[email protected]> >> --- > > > Thanks for the patch > I just submitted one patch to fix the issue, in case you missed it.
Yes I did as I am not subscribed to mmc list. > Also spin_lock is required for atomic accessing DW_MMC_CARD_PRESENT. > Otherwise sd detect may be failed sometimes. > > Could you help take a look. I looked at and tested your patch [1] (which is similar to mine except for the locking part). Since I do not have your patch in my mailbox, FWIW, Reviewed-by: Sachin Kamat <[email protected]> Tested-by: Sachin Kamat <[email protected]> [1] http://permalink.gmane.org/gmane.linux.kernel.mmc/24600 --- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
