On Thu, May 15, 2014 at 11:37 AM, <[email protected]> wrote:
> From: Srinivas Kandagatla <[email protected]> > > This patch adds support to fbclk that is used to latch data and > cmd on some controllers like SD Card controller in Qcom SOC. > > Signed-off-by: Srinivas Kandagatla <[email protected]> (...) Isn't this overkill? @@ -189,6 +192,7 @@ static struct variant_data variant_qcom = { .clkreg = MCI_CLK_ENABLE, - .clkreg_enable = MCI_QCOM_CLK_FLOWENA, + .clkreg_enable = MCI_QCOM_CLK_FLOWENA | MCI_QCOM_CLK_FEEDBACK_CLK, .clkreg_8bit_bus_enable = MCI_QCOM_CLK_WIDEBUS_8, Isn't this achieveing exactly the same thing without the extra fields? You unconditionally do it at every enable anyway, don't you? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
