Hello Ulf,
On Thu, Aug 14, 2014 at 11:26:28AM +0200, Ulf Hansson wrote:
> > diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
> > index 95cceae96944..52e83f389428 100644
> > --- a/drivers/mmc/core/host.c
> > +++ b/drivers/mmc/core/host.c
> > @@ -452,6 +452,14 @@ int mmc_of_parse(struct mmc_host *host)
> > if (of_find_property(np, "mmc-hs400-1_2v", &len))
> > host->caps2 |= MMC_CAP2_HS400_1_2V |
> > MMC_CAP2_HS200_1_2V_SDR;
> >
> > + if (of_find_property(np, "dsr", &len)) {
> > + u32 tmp;
> > +
> > + of_property_read_u32(np, "dsr", &tmp);
> > + host->dsr_req = 1;
> > + host->dsr = (u16)tmp;
> > + }
> > +
>
> Let's simplify the above with just:
> of_property_read_u16(np, "dsr", &host->dsr);
The downside here is that the syntax changes when using
of_property_read_u16. Instead of
dsr = <0x100>
the following must be written then:
dsr = /bits/ 16 <0x100>;
so I'd prefer to stay with of_property_read_u32. The block can still be
simplified. Will fix that in v4.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
