2014-08-22 8:48 GMT+02:00 Barry Song <[email protected]>: > > Minda's version is: > static void sdhci_sirf_set_bus_width(struct sdhci_host *host, int width) > { > u8 ctrl; > > ctrl = sdhci_readb(host, SDHCI_HOST_CONTROL); > ctrl &= ~(SDHCI_CTRL_4BITBUS | SDHCI_SIRF_8BITBUS); > > if (width == MMC_BUS_WIDTH_8) { > /* > * CSR atlas7 and prima2 SD host version is not 3.0 > * 8bit-width enable bit of CSR SD hosts is 3, > * while stardard hosts use bit 5 > */ > ctrl |= SDHCI_SIRF_8BITBUS; > } else if (width == MMC_BUS_WIDTH_4) > ctrl |= SDHCI_CTRL_4BITBUS;
Here, the braces are not right. The coding style requires braces for both sides of an 'else', or none of them > > sdhci_writeb(host, ctrl, SDHCI_HOST_CONTROL); > } > > It is basically same with you. > Yes. >> > You can use it verbatim with my signoff if you want. >> > Signed-off-by: Romain Izard <[email protected]> > > do you mean a Reviewed-by? > In case you wanted to take the code snipplet I provided without changing it, I provided you my Signed-off-by to be sure that there is no issue. Since Minda wrote it on his/her own, it's not necessary. But now, you can use: Reviewed-by: Romain Izard <[email protected]> Best regards, -- Romain Izard -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
