>> >> If you have the possibility to enumerate the device ID (reading >> >> device information directly from the HW), you should do that when >> >> adding the device to its subsystem level bus, not while probing. >> >> That's because you need to be able to match for a compatible driver. >> > Thanks. Could you provide a reference in present code if you know? I'd >> like to try. >> >> I guess the are several subsystem to look into, but maybe AMBA is one >> that you could have a look at. >> >> drivers/amba/bus.c >> > Thank you, Uffe. > I have seen the code of drivers/amba/ and drivers/of/. > Do you suggest to get device information from HW when adding device in > drivers/of ? > I am afraid it still faces the same machine specific problem and is > complicated.
No matter what you need to move things out of the machine specific directory, if you want other drivers/buses to be able to make use of it. Complicated? Maybe, but I don't find that as good argument for not doing it. :-) > > I think it is not so unreasonable to get QorIQ silicon rev in > sdhci-of-esdhc.c, because this file is only used for freescale QorIQ platform. Sorry, I will not accept patches that include machine specific headers. We can do better than that. Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
