On Wed, Aug 26, 2026 at 11:19:32AM +0200, Greg Kroah-Hartman wrote: > Other kernel code might want to call add_taint_module() so pull it out > and make it global. If modules are not enabled, this defaults to a call > to add_taint(), so all is fine. > > Signed-off-by: Greg Kroah-Hartman <[email protected]> > --- > include/linux/module.h | 8 ++++++++ > kernel/module/main.c | 13 +++++++++++-- > 2 files changed, 19 insertions(+), 2 deletions(-) > > diff --git a/include/linux/module.h b/include/linux/module.h > index 96cc98568eea..25221539e645 100644 > --- a/include/linux/module.h > +++ b/include/linux/module.h > @@ -29,6 +29,7 @@ > #include <linux/srcu.h> > #include <linux/static_call_types.h> > #include <linux/dynamic_debug.h> > +#include <linux/panic.h> > > #include <linux/percpu.h> > #include <asm/module.h> > @@ -770,6 +771,8 @@ static inline bool is_livepatch_module(struct module *mod) > > void module_for_each_mod(int(*func)(struct module *mod, void *data), void > *data); > > +void add_taint_module(struct module *mod, unsigned flag, enum lockdep_ok); > + > #else /* !CONFIG_MODULES... */ > > static inline struct module *__module_address(unsigned long addr) > @@ -877,6 +880,11 @@ static inline bool module_is_coming(struct module *mod) > static inline void module_for_each_mod(int(*func)(struct module *mod, void > *data), void *data) > { > } > + > +static inline void add_taint_module(struct module *mod, unsigned flag, enum > lockdep_ok) > +{ > + add_taint(flag, lockdep_ok); > +} > #endif /* CONFIG_MODULES */ > > #ifdef CONFIG_SYSFS > diff --git a/kernel/module/main.c b/kernel/module/main.c > index d0e1e0bd2ad0..99cedb961898 100644 > --- a/kernel/module/main.c > +++ b/kernel/module/main.c > @@ -191,8 +191,17 @@ static inline int strong_try_module_get(struct module > *mod) > return -ENOENT; > } > > -static inline void add_taint_module(struct module *mod, unsigned flag, > - enum lockdep_ok lockdep_ok) > +/** > + * add_taint_module: add a taint flag if not already set for a specific > module > + * @mod: pointer to the module that caused the problem > + * @flag: one of the TAINT_* constants. > + * @lockdep_ok: whether lock debugging is still OK. > + * > + * If something bad has gone wrong, you'll want @lockdebug_ok = false, but > for > + * some noteworthy-but-not-corrupting cases, it can be set to true. > + */ > +void add_taint_module(struct module *mod, unsigned flag, > + enum lockdep_ok lockdep_ok) > { > add_taint(flag, lockdep_ok); > set_bit(flag, &mod->taints); > > -- > 2.55.0 >
Hi Greg, I believe Sashiko [1] found a few valid concerns. [1]: https://sashiko.dev/#/message/20260826102921.5B81B1F000E9%40smtp.kernel.org Kind regards, -- Aaron Tomlin
