On 10/20/26 9:22 PM, Miguel Ojeda wrote: > On Mon, Oct 19, 2026 at 5:13 PM Giuliano Procida <[email protected]> wrote: >> >> This change defines `EXPORT_SYMBOL_RUST_GPL(sym)` using >> `___EXPORT_SYMBOL` directly: >> >> asm(__stringify(___EXPORT_SYMBOL(sym, "GPL", ""))) >> >> matching the `__ASSEMBLY__` path in `include/linux/export.h`. > > Hmm... It says it matches the `__ASSEMBLY__` path, but it matches the > `#else` path, no? > > Cc'ing the `RUST` entry and modules too. > > In addition, I wonder if we should avoid hardcoding the particular > form of that `asm(...` and instead expose it from the C header. That > way we avoid repetition and getting it out-of-sync -- that was part of > the original reasoning.
It should be also ok to move EXPORT_SYMBOL_RUST_GPL() directly into include/linux/export.h. -- Petr
