On Fri, May 05, 2017 at 11:17:14AM -0700, Ricardo Neri wrote:
> @@ -697,18 +753,21 @@ void __user *insn_get_addr_ref(struct insn *insn, 
> struct pt_regs *regs)
>  {
>       unsigned long linear_addr, seg_base_addr, seg_limit;
>       long eff_addr, base, indx;
> -     int addr_offset, base_offset, indx_offset;
> +     int addr_offset, base_offset, indx_offset, addr_bytes;
>       insn_byte_t sib;
>  
>       insn_get_modrm(insn);
>       insn_get_sib(insn);
>       sib = insn->sib.value;
> +     addr_bytes = insn->addr_bytes;
>  
>       if (X86_MODRM_MOD(insn->modrm.value) == 3) {
>               addr_offset = get_reg_offset(insn, regs, REG_TYPE_RM);
>               if (addr_offset < 0)
>                       goto out_err;
> -             eff_addr = regs_get_register(regs, addr_offset);
> +             eff_addr = get_mem_offset(regs, addr_offset, addr_bytes);
> +             if (eff_addr == -1L)
> +                     goto out_err;
>               seg_base_addr = insn_get_seg_base(regs, insn, addr_offset);
>               if (seg_base_addr == -1L)
>                       goto out_err;

This code here is too dense, it needs spacing for better readability.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imend├Ârffer, Jane Smithard, Graham Norton, HRB 21284 
(AG N├╝rnberg)
-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-msdos" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to