Pekka Savola wrote:
> I have loaded SMC Ultra ethernet module successfully with
> 2 different computers. You can't connect to other computers
> from them - the network doesn't work. When I try to remove them
> with rmmod, there will be a kernel oops
[...]
The disallocation of resources wasn't ordered properly. (I'm sure
they [8390-based] all were at some point...) Anyways this should
fix it. I'll go and have a look to make sure the others (2.2 & 2.3)
are ordered properly as well.
Paul.
--- drivers/net/smc-ultra.c~ Thu Sep 30 04:11:31 1999
+++ drivers/net/smc-ultra.c Thu Sep 30 04:26:05 1999
@@ -480,14 +480,14 @@
for (this_dev = 0; this_dev < MAX_ULTRA_CARDS; this_dev++) {
struct device *dev = &dev_ultra[this_dev];
if (dev->priv != NULL) {
- /* NB: ultra_close_card() does free_irq + irq2dev */
+ /* NB: ultra_close_card() does free_irq */
int ioaddr = dev->base_addr - ULTRA_NIC_OFFSET;
- kfree(dev->priv);
- release_region(ioaddr, ULTRA_IO_EXTENT);
unregister_netdev(dev);
- dev->priv = NULL;
+ release_region(ioaddr, ULTRA_IO_EXTENT);
+ kfree(dev->priv);
}
}
+ unlock_8390_module();
}
#endif /* MODULE */
_________________________________________________________
Do You Yahoo!?
Get your free @yahoo.com address at http://mail.yahoo.com
-
To unsubscribe from this list: send the line "unsubscribe linux-net" in
the body of a message to [EMAIL PROTECTED]
