On Tue, Nov 27, 2007 at 11:34:05AM -0800, Frank Filz wrote:
> On Mon, 2007-11-26 at 22:28 +0000, J. Bruce Fields wrote:
> > On Mon, Nov 26, 2007 at 01:19:11PM -0800, Frank Filz wrote:
> > OK, thanks! My only superficial complaint--I find the
> > OBEY_CROSSMNT/IGNORE_CROSSMNT defines to be minor overkill.
> >
> > If you want to stick with them, then you should probably use a
> > comparison to IGNORE_CROSSMNT here instead of assuming which is zero:
> >
> > > + if (!ignore_crossmnt &&
> > > + exp->ex_mnt->mnt_root->d_inode == dentry->d_inode) {
> > > err = vfs_getattr(exp->ex_mnt->mnt_parent,
> > > exp->ex_mnt->mnt_mountpoint, &stat);
> >
> > But I think it'd be simplest just to use 0 and 1 directly instead of the
> > defines.
>
> Ok, here's an updated patch removing the #defines. I did also explicitly
> test ignore_crossmnt for 0 instead of implicitly testing.
OK, in all I think the new version's a little more straightforward.
Thanks! Applied and pushed out to
git://linux-nfs.org/~bfields nfs-server-stable
and should go in 2.6.25.
--b.
-
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
