On Mon, 11 Feb 2008 10:29:38 -0500 "J. Bruce Fields" <[EMAIL PROTECTED]> wrote:
> Oops, did I forget to send this? I don't' see it in the archives. > Apologies: > > On Mon, Feb 11, 2008 at 12:22:08AM +0000, bfields wrote: > > On Thu, Feb 07, 2008 at 04:34:55PM -0500, Jeff Layton wrote: > > ... > > > diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c > > > index 0822646..378b393 100644 > > > --- a/fs/lockd/svc.c > > > +++ b/fs/lockd/svc.c > > ... > > > @@ -174,6 +167,10 @@ lockd(struct svc_rqst *rqstp) > > > } else if (time_before(grace_period_expire, jiffies)) > > > clear_grace_period(); > > > > > > + /* nlmsvc_retry_blocked can block, so check for kthread_stop */ > > > + if (kthread_should_stop()) > > > + break; > > > > The following svc_recv call will check kthread_should_stop() pretty > > early on, so I don't believe this is necessary? > > > > Assuming that's correct, I've deleted these lines and applied the rest. > > Sounds reasonable...ACK -- Jeff Layton <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
