On Thu, 2013-04-25 at 10:49 +0300, Dan Carpenter wrote: > [ It's weird that kbuild didn't catch this ]. > > Hello Vyacheslav Dubeyko, > > The patch bb594c4767b0: "nilfs2: fix issue with flush kernel thread > after remount in RO mode because of driver's internal error or > metadata corruption" from Apr 18, 2013, leads to the following > warning: > "fs/nilfs2/inode.c:211 nilfs_writepage() > error: we previously assumed 'inode' could be null (see line 195)" >
Please, find below the patch with fix. Thanks, Vyacheslav Dubeyko. -- From: Vyacheslav Dubeyko <[email protected]> Subject: [PATCH] nilfs2: fix warning in nilfs_writepage() The patch fixes warning: "fs/nilfs2/inode.c:211 nilfs_writepage() error: we previously assumed 'inode' could be null (see line 195)". Reported-by: Dan Carpenter <[email protected]> Signed-off-by: Vyacheslav Dubeyko <[email protected]> CC: Ryusuke Konishi <[email protected]> --- fs/nilfs2/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nilfs2/inode.c b/fs/nilfs2/inode.c index ba7a1da..cf02f55 100644 --- a/fs/nilfs2/inode.c +++ b/fs/nilfs2/inode.c @@ -192,7 +192,7 @@ static int nilfs_writepage(struct page *page, struct writeback_control *wbc) struct inode *inode = page->mapping->host; int err; - if (inode && (inode->i_sb->s_flags & MS_RDONLY)) { + if (inode->i_sb->s_flags & MS_RDONLY) { /* * It means that filesystem was remounted in read-only * mode because of error or metadata corruption. But we -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
