From: Vyacheslav Dubeyko <[email protected]> Subject: [PATCH] nilfs2: fix issue with potential infinite loop in nilfs_mdt_get_block()
Potentially, there are situations when nilfs_mdt_read_block() can return -ENOENT and nilfs_mdt_create_block() can return -EEXIST. Such situation results in infinite loop inside nilfs_mdt_get_block() method. This patch fixes issue with potential infinite loop in nilfs_mdt_get_block() by means of uncomment limitation of read-create loop retries. Signed-off-by: Vyacheslav Dubeyko <[email protected]> CC: Vyacheslav Dubeyko <[email protected]> CC: Ryusuke Konishi <[email protected]> --- fs/nilfs2/mdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nilfs2/mdt.c b/fs/nilfs2/mdt.c index c4dcd1d..d1e121f 100644 --- a/fs/nilfs2/mdt.c +++ b/fs/nilfs2/mdt.c @@ -254,7 +254,7 @@ int nilfs_mdt_get_block(struct inode *inode, unsigned long blkoff, int create, ret = nilfs_mdt_create_block(inode, blkoff, out_bh, init_block); if (unlikely(ret == -EEXIST)) { - /* create = 0; */ /* limit read-create loop retries */ + create = 0; /* limit read-create loop retries */ goto retry; } return ret; -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
