On Fri, 2014-09-05 at 11:41 +0900, Hitoshi Mitake wrote:
[snip]
> diff --git a/fs/nilfs2/segment.h b/fs/nilfs2/segment.h
> index 38a1d00..1e9b931 100644
> --- a/fs/nilfs2/segment.h
> +++ b/fs/nilfs2/segment.h
> @@ -66,13 +66,14 @@ struct nilfs_recovery_info {
>
> /**
> * struct nilfs_cstage - Context of collection stage
> - * @scnt: Stage count
> + * @__scnt: Stage count, must be accessed via wrappers:
> + * nilfs_sc_cstage_inc(), nilfs_sc_cstage_set(),
> nilfs_sc_cstage_get()
> * @flags: State flags
> * @dirty_file_ptr: Pointer on dirty_files list, or inode of a target file
> * @gc_inode_ptr: Pointer on the list of gc-inodes
> */
> struct nilfs_cstage {
> - int scnt;
> + int __scnt;
It doesn't make sense this change for my taste. As far as I can judge,
you've made this change because scnt field should be accessed by means
of wrappers. But __scnt name doesn't provide from direct using this
field. So, I suppose that extended comment will be enough.
By the way, do you plan to add tracepoints for another NILFS2
subsystems?
Thanks,
Vyacheslav Dubeyko.
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
