On Wed, Sep 14, 2016 at 11:07:59AM -0600, Ross Zwisler wrote: > I'll bite - why do you think adding a space before labels is a "fairly > horrible style"?
It introduces single whitespace indentation in a source base that is all about tabs and uses whitespaces very sparingly (some people use it to align function arguments, while others also consistently use tabs). It's also a bit annoying when touching these error label chains for any sort of major change. > Adding them gives a tangible benefit for unified diffs and > patches because it's much more useful to know that a change is in a given > function than that it follows a label called "out", which could be defined > many times in a given file. Again, the example: Yes, but this is just diff beeing stupid. There is no reason why diff couldn't handle this properly even without the space, and in fact at least git diff can be tought easily to do just that. There are a few threads about this label style going on on lkml in the last week, and one of them mentions the git diff tweak. Try searching for "Clarify and complete chapter 7". _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
