On 02/13/2017 12:32 PM, Dan Williams wrote: > On Mon, Feb 13, 2017 at 8:27 AM, Linda Knippers <[email protected]> > wrote: >> Newline in MODULE_PARM_DESC messes up the modprobe output so remove it. > > Yes, looks good. When this "messes up" does that mean the output less > pretty, or do you know if it breaks scripts parsing the output? Just > want to be clear on the effects of this change.
If you do a 'modinfo nfit', it puts "(bool)" on a separate line. That's unlike all the other parameters. If someone is parsing the output of modinfo, they may not get the type. Without my patch, you get this: parm: force_enable_dimms:Ignore _STA (ACPI DIMM device) status (bool) parm: scrub_timeout:Initial scrub timeout in seconds (uint) parm: scrub_overflow_abort:Number of times we overflow ARS results before abort (uint) parm: disable_vendor_specific:Limit commands to the publicly specified set (bool) parm: default_dsm_family:Try this DSM type first when identifying NVDIMM family (int) instead of this: parm: force_enable_dimms:Ignore _STA (ACPI DIMM device) status (bool) parm: scrub_timeout:Initial scrub timeout in seconds (uint) parm: scrub_overflow_abort:Number of times we overflow ARS results before abort (uint) parm: disable_vendor_specific:Limit commands to the publicly specified set (bool) parm: default_dsm_family:Try this DSM type first when identifying NVDIMM family (int) -- ljk _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
