On Thu, Mar 23, 2017 at 4:47 PM, Lijun Pan <[email protected]> wrote: > From: Lijun Pan <[email protected]> > > "ndctl msft-dsm" shows more generic NVDIMM info (except health) > via calling _DSM functions. > > Cc: Stuart Hayes <[email protected]> > Signed-off-by: Lijun Pan <[email protected]> > --- > Documentation/Makefile.am | 1 + > Documentation/ndctl-msft-dsm.txt | 83 ++++++++++++++++++ > builtin.h | 1 + > ndctl/Makefile.am | 1 + > ndctl/builtin-msft-dsm.c | 173 +++++++++++++++++++++++++++++++++++++ > ndctl/ndctl.c | 1 + > ndctl/util/json-msft.c | 179 > +++++++++++++++++++++++++++++++++++++++ > util/json.h | 1 + > 8 files changed, 440 insertions(+) > create mode 100644 Documentation/ndctl-msft-dsm.txt > create mode 100644 ndctl/builtin-msft-dsm.c
Hi Lijun. This is great, thank you for extending ndctl support for the Microsoft family of DIMMs! However, I'll give the same feedback I gave to the initial HPE support implementation. As much as possible I want to avoid having DIMM family specific enabling in the ndctl utility itself. It should all live behind an abstraction provided by libndctl. That way other applications that might use libndctl directly can get the benefit of the enabling. The approach we took in the HPE case is to introduce ndctl_smart_ops and merge the smart payloads into a common json format. While the current enabling only exposes the SMART health fields that are similar between Intel and HPE, it need not be that way going forward and I'm open to having json fields that are DIMM-family exclusive. Have a look at extending the existing "ndctl list --dimms --health" output with Microsoft-specific fields, but otherwise reuse existing fields where they are common across other DIMM families. _______________________________________________ Linux-nvdimm mailing list [email protected] https://lists.01.org/mailman/listinfo/linux-nvdimm
